Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-manifest): create directories recursively #27793

Merged
merged 3 commits into from
Nov 2, 2020
Merged

fix(gatsby-plugin-manifest): create directories recursively #27793

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7168e1a
fix(gatsby-plugin-manifest): create directories recursively
KyleAMathews Nov 2, 2020
f9a3a23
fix typo
KyleAMathews Nov 2, 2020
794bf4a
fix tests
KyleAMathews Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(gatsby-plugin-manifest): create directories recursively 
It's possible to have directories nested multiple layers deep or potentially that `public` isn't defined.
  • Loading branch information
@KyleAMathews
KyleAMathews authored Nov 2, 2020
commit 7168e1a1e984a635695e97b42bf623258b266ed2
2 changes: 1 addition & 1 deletion packages/gatsby-plugin-manifest/src/gatsby-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ const makeManifest = async ({
const exists = fs.existsSync(iconPath)
//create destination directory if it doesn't exist
if (!exists) {
fs.mkdirSync(iconPath)
fs.mkdirSync(iconPath, , { recursive: true })
KyleAMathews marked this conversation as resolved.
Show resolved Hide resolved
}
paths[iconPath] = true
}
Expand Down