Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): allow configuration of default socket type #27734

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

wardpeet
Copy link
Contributor

Description

Add an env var so we can set the default websocket type. It should fix long running websocket issues. When a faulty transport is given than socket.io will fallback to polling anyway.

@wardpeet wardpeet requested a review from a team as a code owner October 30, 2020 18:39
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 30, 2020
KyleAMathews
KyleAMathews previously approved these changes Oct 30, 2020
pieh
pieh previously approved these changes Oct 30, 2020
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just consider env var name

packages/gatsby/src/utils/webpack.config.js Outdated Show resolved Hide resolved
@wardpeet wardpeet dismissed stale reviews from pieh and KyleAMathews via bb2aa8a October 30, 2020 18:53
@wardpeet wardpeet merged commit f43a6bd into gatsbyjs:master Oct 30, 2020
@wardpeet wardpeet deleted the feat/socket-type branch October 30, 2020 19:32
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants