Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): rename the Github learning team #26673

Merged
merged 7 commits into from
Sep 22, 2020

Conversation

janson
Copy link
Contributor

@janson janson commented Aug 27, 2020

Description

This is essentially an administrative clarification—this is an alignment move to avoid future confusion.

Related Issues

Once merged, make the associated naming change in GitHub to handle auto-tagging of the team.

[ch11559]

- Update team name in CODEOWNERS
- Update team name references in docs

[ch11559]
@janson janson requested a review from AishaBlake August 27, 2020 23:16
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 27, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 27, 2020

Gatsby Cloud Build Report

using-styled-components

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 20s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 90
Best Practices 💚 100
SEO 💚 90

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 27, 2020

Gatsby Cloud Build Report

using-reach-skip-nav

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 21s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 82

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 27, 2020

Gatsby Cloud Build Report

client-only-paths

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 18s

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 🔶 85
Best Practices 💚 100
SEO 🔶 70

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 27, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 29m

@janson janson changed the title Rename the Github learning team chore(docs): rename the Github learning team Aug 28, 2020
@vladar vladar added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 28, 2020
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of suggestions. Thanks for your patience while I caught up after PTO!

docs/contributing/how-to-write-a-reference-guide.md Outdated Show resolved Hide resolved
docs/contributing/managing-pull-requests.md Outdated Show resolved Hide resolved
@AishaBlake AishaBlake added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: needs docs review Pull request related to documentation waiting for review labels Sep 2, 2020
@AishaBlake
Copy link

@janson I can go ahead and make the first change I suggested but I'm not 100% sure on the second. Maybe @gillkyle would be willing to weigh in there?

@janson janson requested a review from AishaBlake September 14, 2020 18:45
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the other instances of that GitHub project list item and I think this is good to go.

@AishaBlake AishaBlake merged commit 510370d into master Sep 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the docs-learning-team-rename branch September 22, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants