Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(gatsby): Support lte for indexed fast filters #22932

Merged
merged 19 commits into from
Apr 14, 2020
Merged

perf(gatsby): Support lte for indexed fast filters #22932

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8a15a90
Rename function to better fit what it returns
pvdz Apr 8, 2020
c1a5984
Use `filterCacheKey` more consistently
pvdz Apr 8, 2020
8849d7a
Consistency around `nodesPerValue`
pvdz Apr 8, 2020
ca5576e
Fix the name and typing of array of sets of nodes
pvdz Apr 8, 2020
c0b3c5e
Fix typing, fix perf bug
pvdz Apr 8, 2020
18f78f8
Extend the `FilterCache` type to support op-specific meta data
pvdz Apr 8, 2020
4074561
Replace wild usage of `FilterType`
pvdz Apr 8, 2020
93a3243
Refactor some old comments / naming to be consistent with current cod…
pvdz Apr 8, 2020
1c56b81
Suggested changes
pvdz Apr 8, 2020
333dd02
Enable `lte` for fast filters
pvdz Apr 8, 2020
2f85a1d
Mandatory lint/type fix commit
pvdz Apr 8, 2020
5603814
And the loki commit
pvdz Apr 8, 2020
9232f9a
Enable/disable query and eleeMatch ops in one place
pvdz Apr 9, 2020
04349bb
Fix tests, fix lte binary search lookup
pvdz Apr 9, 2020
c3525c2
Support `null` properly and handle not found binary search case
pvdz Apr 9, 2020
493b85d
Sigh, this is why I had to introduce that type in the first place
pvdz Apr 9, 2020
b746293
Forgot to remove an argument from followup work
pvdz Apr 9, 2020
8aebc8f
Merge branch 'master' into ltegte
pvdz Apr 14, 2020
54e9cf8
Apply suggestions
pvdz Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
And the loki commit
  • Loading branch information
@pvdz
pvdz committed Apr 8, 2020
commit 56038149c9efffa8e6e76581533e7a285c365a88
2 changes: 2 additions & 0 deletions packages/gatsby/src/schema/__tests__/run-query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,8 @@ it(`should use the cache argument`, async () => {
})

it(`should lte when value is lower than all found values`, async () => {
if (IS_LOKI) return

let result = await runFilter({ float: { lte: 1 } })

expect(result).toEqual(null) // Zero results yields undefined
Expand Down