-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): change bash to shell in code language blocks #22899
fix(docs): change bash to shell in code language blocks #22899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two comments
good catch. in line 209 it says it is in both: gatsby/packages/gatsby-remark-prismjs/README.md Lines 209 to 210 in 2a7cb8c
maybe (in a new PR) would be good to add the gatsby/packages/gatsby-remark-prismjs/src/index.js Lines 91 to 96 in 2f0044d
- [`bash`].includes(languageName) &&
+ [`bash`,`shell`].includes(languageName) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed "$" from the shell commands
i think all requested changes are solved... |
fixed in: #23256 fix(gatsby-remark-prismjs): Update useCommandLine
# Conflicts: # docs/blog/2018-04-04-gatsby-contentful-starter-tutorial/index.md # docs/blog/2020-01-08-git-workflows/index.md
896ffed
to
488a0cb
Compare
merged from master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🎉 |
Description
changed:
bash
toshell
regarding the code style guides to prefershell
Related links