Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: (scripts/i18n) Check if an existing sync PR exists before creating a new one. #22617

Merged
merged 8 commits into from
Apr 9, 2020
Merged

feature: (scripts/i18n) Check if an existing sync PR exists before creating a new one. #22617

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
36f3d50
do not create a new pull request if a label exists
tesseralis Mar 28, 2020
51a7991
Add the labels to the created PRs
tesseralis Mar 28, 2020
565dd13
remove todo
tesseralis Mar 28, 2020
24ede70
spelling error
tesseralis Mar 28, 2020
fc882cf
remove debug code
tesseralis Mar 28, 2020
9950b12
Merge branch 'master' into sync-label
tesseralis Apr 6, 2020
5763dd9
aliases in getRepository for clarity
tesseralis Apr 7, 2020
1df8e6d
whoops
tesseralis Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spelling error
  • Loading branch information
@tesseralis
tesseralis committed Mar 28, 2020
commit 24ede7040550232e54b20c145aaf55cd6489dca7
4 changes: 3 additions & 1 deletion scripts/i18n/sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,8 @@ async function syncTranslationRepo(code) {
syncLabel = repository.label
}

// process.exit(0)

// TODO exit early if this fails
// Compare these changes
const baseHash = shell
Expand Down Expand Up @@ -323,7 +325,7 @@ async function syncTranslationRepo(code) {
draft: true,
})

logger.info(`Adding ${syncLabelName} lables to created pull requests...`)
logger.info(`Adding ${syncLabelName} labels to created pull requests...`)
await addLabelToPullRequest(syncPR, syncLabel)
await addLabelToPullRequest(conflictsPR, syncLabel)
}
Expand Down