Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make 11321 and 11330 error formatters backward compatible #22249

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Mar 13, 2020

#20597 renamed some field names for consistency with other errors, but this is dangerous because errorMap and error showing are in different packages which versions might drift, so we do need to add a bit of compat code (to fallback to previous fieldname if new one is undefined)

@pieh pieh requested a review from a team as a code owner March 13, 2020 14:26
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy ?? 🌮

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 13, 2020
@gatsbybot gatsbybot merged commit 6b01efe into gatsbyjs:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants