Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-contentful): Remove whitespace from default long text value #21412

Merged
merged 1 commit into from
Feb 12, 2020
Merged

fix(gatsby-source-contentful): Remove whitespace from default long text value #21412

merged 1 commit into from
Feb 12, 2020

Conversation

mrseanbaines
Copy link
Contributor

Description

As described in the linked issue, currently when querying an empty "long text" field with the gatsby-source-contentful package, a string with a single whitespace character is returned. It seems this whitespace serves no purpose and makes falsy checks unintuitive and overcomplicated. This PR simply removes the unnecessary whitespace.

Related Issues

Fixes #20579

@mrseanbaines mrseanbaines requested a review from a team as a code owner February 12, 2020 20:33
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 12, 2020
@gatsbybot gatsbybot merged commit bed3684 into gatsbyjs:master Feb 12, 2020
@mrseanbaines mrseanbaines deleted the fix/gatsby-source-contentful-long-text-whitespace branch February 13, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
3 participants