Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(www): consolidate getting the excerpt from blog posts #21386

Merged
merged 1 commit into from
Feb 19, 2020
Merged

refactor(www): consolidate getting the excerpt from blog posts #21386

merged 1 commit into from
Feb 19, 2020

Conversation

tesseralis
Copy link
Contributor

Define the excerpt field in onCreateNode instead of checking between page.excerpt and page.frontmatter.excerpt every time we use it.

TODO: Maybe consolidate with frontmatter.description from the docs?

@tesseralis tesseralis requested a review from a team as a code owner February 12, 2020 02:54
LekoArts
LekoArts approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LekoArts LekoArts merged commit 27aeb08 into gatsbyjs:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

@sidharthachatterjee sidharthachatterjee Awaiting requested review from sidharthachatterjee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesseralis @LekoArts