-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(www): Adds CodeSandbox in Try this starter #20948
Conversation
I will just check how adding more items to "Try this starter" impacts displayed information on narrow viewports (mostly worried about "mobile/portrait" case). But general feature to add CodeSandbox has "+1" from me! |
It looks like that section gets hidden altogether on smaller viewports |
Hmm, the svg imports seems to just come out as |
@pieh Thanks for the feedback. I've got the icons working, and added some whitespace between the options. |
If you have site running locally - could you paste some screenshots for folks to see? If not, I'll just update mine to use your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thank you so much ❤️
Holy buckets, @garethx — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Description
This PR adds a CodeSandbox option to 'Try this starter' on starter pages. Like Netlify, you can deploy the starter but with the CodeSandbox option folks will also be able to see and edit a copy of the code to test out changes to the starter too.