Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-link): Adds Type, PropType, tests, and docs for state prop #20807

Merged
merged 5 commits into from
Feb 1, 2020

Conversation

ptim
Copy link
Contributor

@ptim ptim commented Jan 23, 2020

Description

Adds Type, PropType, tests, and docs for state prop

Documentation

Updates https://www.gatsbyjs.org/docs/location-data-from-props/#example-of-providing-state-to-a-link-component to agree with https://www.gatsbyjs.org/docs/gatsby-link/ and cross links both documents.

Another relevant page is https://www.gatsbyjs.org/docs/linking-between-pages/ but this already links to the GatsbyLink API docs, so I'm avoiding link soup here. Can add more cross linking if required.

Related Issues

Related to: #3552

@ptim ptim requested review from a team as code owners January 23, 2020 04:21
pieh
pieh previously requested changes Jan 27, 2020
packages/gatsby-link/index.d.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid stuff!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 1, 2020
@sidharthachatterjee sidharthachatterjee merged commit d8937d0 into gatsbyjs:master Feb 1, 2020
@gatsbot
Copy link

gatsbot bot commented Feb 1, 2020

Holy buckets, @ptim — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@ptim
Copy link
Contributor Author

ptim commented Feb 15, 2020

Woah - I missed all the action! Thanks so much everyone 😀🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants