Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure to throw proper errors #20750

Merged
merged 2 commits into from
Jan 21, 2020
Merged

make sure to throw proper errors #20750

merged 2 commits into from
Jan 21, 2020

Conversation

mathieudutour
Copy link
Contributor

Description

Documentation

Related Issues

@mathieudutour mathieudutour requested a review from a team as a code owner January 21, 2020 16:01
@mathieudutour mathieudutour mentioned this pull request Jan 21, 2020
Merged
8 tasks
pvdz
pvdz approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! :)

@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 21, 2020
@pvdz pvdz self-requested a review January 21, 2020 16:15
@pvdz pvdz removed the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 21, 2020
pvdz
pvdz suggested changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update tests to reflect an Error to be thrown instead of a plain string

@pvdz
Copy link
Contributor

pvdz commented Jan 21, 2020

Awesome, thanks! :D

@pvdz pvdz added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 21, 2020
@gatsbybot gatsbybot merged commit a9f0b38 into master Jan 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the f/make-sure-to-throw-errors branch January 21, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathieudutour @pvdz @gatsbybot