Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typing): more precise typing for ssr api #20564

Merged
merged 2 commits into from
Jan 13, 2020
Merged

fix(typing): more precise typing for ssr api #20564

merged 2 commits into from
Jan 13, 2020

Conversation

Austaras
Copy link
Contributor

Description

Typing for gatsby ssr api is wrong and too generic

@Austaras Austaras requested a review from a team as a code owner January 13, 2020 02:06
@Austaras Austaras requested a review from orta January 13, 2020 02:07
@orta
Copy link
Contributor

orta commented Jan 13, 2020

Yeah cool, I don't know the exact API shape but these feel better to me 👍

LekoArts
LekoArts approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@LekoArts LekoArts merged commit b53ec9a into master Jan 13, 2020
@LekoArts LekoArts deleted the ssr-type branch January 13, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

@orta orta Awaiting requested review from orta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Austaras @orta @LekoArts