fix(gatsby-cli): normalize case of windows drive letter #20437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wardpeet Mind reviewing? As you are my companion in the misfortune of using Windows 😃 |
blainekasten
reviewed
Jan 6, 2020
pieh
reviewed
Jan 6, 2020
|
How do I test this? |
|
@wardpeet Switch to lowercase There is also another repo: https://github.com/murnana/gatsby-bug-repo/tree/feature/gatsbyjs%2319863 which produces webpack warnings on |
vladar
force-pushed
the
vladar/gh-19863
branch
from
dd04841
to
8a0b51d
Compare
wardpeet
reviewed
Jan 14, 2020
|
Published in |
|
Hi, I hate to comment on a PR that already fixed this issue #19863 but I'm still getting that error. If there's anything I'm missing here please let me know and thank you in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the current working directory on Windows always has an uppercase drive letter (i.e., C: vs. c:).
Motivation
Different utils like "true-case-path", "normalize-path", "slash" treat Windows drive letter differently. "true-case-path" will uppercase, others usually don't care. As a result path normalization produces different results depending on current cwd (c: vs. C:) which manifests in weird issues that are very hard to debug (see related issues bellow).
Ad-hoc fixes like the one introduced in #17492 address the part of the problem but anytime you want to compare a path that is normalized this way you must remember about it and normalize the other side of the comparison the same way.
This is not maintainable (and is especially annoying for those who do not use Windows as they cannot even test it). Things get even worse because we can't really control community plugins or site code but everything should still be working even with a different set of libraries.
This PR is meant to be a general solution to this problem and (hopefully) fix it for good.
Documentation
N/A (as this is a bugfix)
Related Issues
Profiscience/true-case-path#3
#16721
#17811
Fixes #19863