Infer value of date objects fixes #1952 #1964
Conversation
|
@jquense seem reasonable? |
|
Deploy preview ready! Built with commit 4def48c |
| @@ -18,6 +18,8 @@ const areAllSameType = list => | |||
| const isEmptyObjectOrArray = (obj: any): boolean => { | |||
| if (obj === INVALID_VALUE) { | |||
| return true | |||
| } else if (_.isDate(obj)) { | |||
| return false | |||
There was a problem hiding this comment.
does the below branch not catch this already?
There was a problem hiding this comment.
No it's reported as an empty object
| @@ -129,7 +129,7 @@ function inferGraphQLType({ | |||
| }, | |||
| }, | |||
| resolve(object, { fromNow, difference, formatString }) { | |||
| const date = object[fieldName] | |||
| const date = object[fieldName].toString() | |||
There was a problem hiding this comment.
does toISOString() make more sense as a default? its a bit less culture dependent
There was a problem hiding this comment.
Will fix later
There was a problem hiding this comment.
Needed to do JSON.parse(JSON.stringify(date)) as date could just be a string so this seemed simplest. The internets say that JSON.stringify uses Date.toISOString under the hood anyways.
|
Deploy preview failed. Built with commit 4def48c https://app.netlify.com/sites/using-glamor/deploys/59a63d61cf321c54a9547048 |
|
Yeah! Travis is back to green! |
No description provided.