Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): check titles, headlines & text + change some NOTE to Note #18654

Merged
merged 5 commits into from
Oct 15, 2019

Conversation

codingCookie
Copy link
Contributor

Description

This PR introduces some minor changes in the docs/mdx folder.

What have i done?

  • changed some headlines to fit the style guide
  • changed NOTE to Note - to get it the same in every file
  • changed Mdx to MDX
  • a few minor text changes to get a more active voice

Related Issues

Related to #18284

@codingCookie codingCookie requested a review from a team as a code owner October 14, 2019 18:51
@codingCookie
Copy link
Contributor Author

@marcysutton can you have a look at the CircleCI Tests? 2 of them failed.
CircleCI said in integration_tests_structured_logging

...
> node-gyp rebuild || node suppress-error.js

gyp WARN EACCES user "root" does not have permission to access the dev dir "/root/.node-gyp/10.16.3"
gyp WARN EACCES attempting to reinstall using temporary dev dir "/usr/local/lib/node_modules/gatsby-dev-cli/node_modules/dtrace-provider/.node-gyp"
.....

and in themes_e2e_tests_production_runtime

...
configure error 
Error: EACCES: permission denied, mkdir '/usr/local/lib/node_modules/gatsby-dev-cli/node_modules/dtrace-provider/.node-gyp'
...

Have I done anything wrong?

@LekoArts LekoArts changed the title docs/mdx: check titles, headlines & text + change some NOTE to Note chore(docs): check titles, headlines & text + change some NOTE to Note Oct 15, 2019
@LekoArts LekoArts added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Oct 15, 2019
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The failing CI tests are/were unrelated to your PR, for docs the most important one is the lint one. I changed two things as "Markdown" is its own noun and a little typo fix.

@LekoArts LekoArts added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Oct 15, 2019
@LekoArts LekoArts merged commit 6e7b186 into gatsbyjs:master Oct 15, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 15, 2019

Holy buckets, @codingCookie — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@codingCookie codingCookie deleted the docs/audit-mdx-folder branch October 15, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants