Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Fix lerna concurrency #16973

Merged
merged 2 commits into from
Aug 23, 2019
Merged

chore(ci): Fix lerna concurrency #16973

merged 2 commits into from
Aug 23, 2019

Conversation

sidharthachatterjee
Copy link
Contributor

The new dependency updates seem to cause lerna/lerna#1798 and bootstrap fails as a result on CircleCI.

This is happening because CircleCI incorrectly reports the number of CPUs and lerna tries to run too many at once and runs out of memory.

The fix here is to set concurrency to 2 for lerna prepare (only when running in CI)

@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner August 22, 2019 23:11
KyleAMathews
KyleAMathews approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It's so weird that circleci has this bug

@sidharthachatterjee
Copy link
Contributor Author

@KyleAMathews Yeah, really frustrating that they misreport os.cpus()

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 22, 2019
@wardpeet
Copy link
Contributor

Please think of windows users :) This change won't allow me to bootstrap.

\"lerna-prepare -- --{@}\" --" this voodoo is breaking windows.
npm-run-all -s "lerna-prepare -- --{@}" -- --concurrency=2

@wardpeet wardpeet removed the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 22, 2019
@sidharthachatterjee sidharthachatterjee mentioned this pull request Aug 22, 2019
Merged
wardpeet
wardpeet reviewed Aug 22, 2019
View reviewed changes
package.json Show resolved Hide resolved
@sidharthachatterjee
Copy link
Contributor Author

@wardpeet Voodoo seemed to have worked fine on Windows ;)

https://circleci.com/gh/gatsbyjs/gatsby/203683?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

This runs yarn bootstrap

@sidharthachatterjee sidharthachatterjee self-assigned this Aug 23, 2019
@wardpeet wardpeet merged commit 42c1c5e into master Aug 23, 2019
@wardpeet wardpeet deleted the fix-lerna-concurrency-on-ci branch August 23, 2019 07:57
@sidharthachatterjee
Copy link
Contributor Author

This was caused by lerna/lerna#1931 by the way which was in a new lerna version which we upgraded to recently in our mass upgrade!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees

@sidharthachatterjee sidharthachatterjee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidharthachatterjee @wardpeet @KyleAMathews