fix(gatsby): Move importing of match-paths.json outside of loader.js #14732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! we are getting the same issue |
wardpeet
changed the title
wardpeet
approved these changes
Jun 13, 2019
Contributor
wardpeet
left a comment
wardpeet
left a comment
There was a problem hiding this comment.
Works like a charm! ❤️ Thanks for fixing this so quickly
Contributor
|
Published in |
mxxk
pushed a commit
to mxxk/gatsby
that referenced
this pull request
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As raised in #14729, Gatsby-link can be used independently of Gatsby itself. And it depends on
loader.jsto enqueue pages for prefetching. Gatsby prescribes overriding those loader functions to be noops, but it still has to compileloader.js.The problem is that the per-page-manifest changes introduced a
match-paths.jsoninto the loader itself. Which won't compile if a gatsby build hasn't occured. To fix, I moved it out into production-app.js and app.js, and then dynamically set it.Related Issues