fix(gatsby-plugin-offline): use networkFirst caching for page-data.json files #14720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSchau
changed the title
wardpeet
reviewed
Jun 12, 2019
Contributor
wardpeet
left a comment
wardpeet
left a comment
There was a problem hiding this comment.
url pattern seems to be working. Should we add a $ to the end of the regex?
I'll give it a spin just to make sure but looks great!
wardpeet
approved these changes
Jun 12, 2019
Contributor
wardpeet
left a comment
wardpeet
left a comment
There was a problem hiding this comment.
Works like a charm. What do you think of adding the $ at the end of the regex?
Contributor
Author
|
Thanks for testing! I don't mind about the |
Contributor
|
Yeah, seems fine without it. Merging! |
mxxk
pushed a commit
to mxxk/gatsby
that referenced
this pull request
Jun 21, 2019
…on files (gatsbyjs#14720) * In plugin-offline, use networkFirst caching for page-data.json files * fix page-data offline regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
page-data.jsonfiles are not content hashed. Their value can change between builds and the filename will remain the same. Therefore, in the offline plugin, we should use networkFirst strategy.Related Issues