Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): warn if trying to create a page with similar path for trailing/non-trailing #13470

Merged

Conversation

Moocar
Copy link
Contributor

@Moocar Moocar commented Apr 18, 2019

Description

Warn if trying to create a page whose path is the same as an existing page, but with or without a trailing slash. See #13464

Related Issues

@Moocar Moocar requested a review from a team as a code owner April 18, 2019 21:25
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Worth adding a test for this behavior, perhaps?

@DSchau DSchau changed the title Warn if trying to create a page whose path is similarly slashed fix(gatsby): warn if trying to create a page with similar path for trailing/non-trailing Apr 18, 2019
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants