refactor(gatsby): Refactor query calc query ids #13063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2019
Moocar
force-pushed
the
query-queue-refactor-calc-query-ids
branch
2 times, most recently
from
5f255d7 to
6267987
Compare
Contributor
Author
|
ready for review |
DSchau
added
the
status: awaiting reviewer response
Moocar
force-pushed
the
query-queue-refactor-calc-query-ids
branch
from
6267987 to
9530a45
Compare
Contributor
|
Nice! Yeah, these names were holdovers from pre-static queries and didn't get updated for that. |
Contributor
Author
|
Published in gatsby@2.3.24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A purely cosmetic refactor. I found the logic in
page-query-runner/runQueriesdifficult to get my head around. Hopefully it's a little better now but I'm sure it can still be improved.Related Issues