refactor(gatsby): expicitly call db saveState and autoSave

[Moocar]

Description

As part of my work on #13004, I've been trying to remove reliance on global events such as BOOTSTRAP_FINISHED. There are definitely some good use cases for global events, but I feel in this case, the code is more clear by specifically invoking db.saveState/autoSave. Curious on other's thoughts.

Related Issues

• Sub-PR of [WIP] Replace global data.json with page-data.json per page #13004

[wardpeet]

Thanks! This is more readable!

Just wondering why we're listening on emitter and not on the redux state changing itself (perhaps redux state change is happening to often?)

I'm holding off on merges as I want @pieh to have a look as well.

[Moocar]

Just wondering why we're listening on emitter and not on the redux state changing itself

Do you mean by registering a reducer that reacts to any redux action? My guess is that we would have no guarantee that all other reducers had executed before performing the save. Whereas emitter is emitted via a subscription to redux, which is guaranteed to fire after all reducers have finished.

[pieh]

I think we need to remove startAutosave call from bootstrap with this?

gatsby/packages/gatsby/src/bootstrap/index.js

Line 26 in 748f833

require(`../db`).startAutosave()

[Moocar]

I think we need to remove startAutosave call from bootstrap with this?

Good catch. Fixed in 5028776

[Moocar]

@pieh conflicts resolved

[sidharthachatterjee]

Published in gatsby@2.3.14