Skip to content

Conversation

Moocar
Copy link
Contributor

@Moocar Moocar commented Apr 1, 2019

Description

While working on #13004 I noticed that build-html/develop-html are essentially the same thing. So I refactored them to be so.

Related Issues

@Moocar Moocar requested a review from a team April 1, 2019 22:43
@Moocar Moocar force-pushed the build-html-separate-compile-and-render branch from 4a1659d to 38374c9 Compare April 2, 2019 05:16
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring is 👌

Just added 2 comments but they aren't blocking so leaving it in the hand of @pieh

@Moocar Moocar force-pushed the build-html-separate-compile-and-render branch from 7ab87de to 931ada4 Compare April 3, 2019 00:32
@Moocar Moocar merged commit 1534fe5 into gatsbyjs:master Apr 3, 2019
@Moocar Moocar deleted the build-html-separate-compile-and-render branch April 3, 2019 20:45
@DSchau
Copy link
Contributor

DSchau commented Apr 3, 2019

Successfully published:

  • gatsby@2.3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants