feat(gatsby-dev-cli): add verdaccio support #11525

pieh · 2019-02-03T16:59:09Z

This adds verdaccio (self run/hosted NPM registry) support to gatsby-dev-cli. There is no extra configuration required - it's all handled internally by gatsby-dev-cli.

Goals:

most important - handle dependency changes
remove extra manual work when using it - remove the need to install dependencies before using gatsby-dev (i.e instead of running yarn you just run gatsby-dev and it handles dependency installation and also changes from monorepo). If deps are installed and dependency didn't change - it will not add extra step of installing deps in local site

The way it works:

on initial monorepo package file globbing it will examine package.json files:
- if package is already installed locally in example site it will compare dependencies in that package. If new dependency was added, or dependency changed version selector/range - it will queue publishing for that package.
- if package is not yet installed - it will check unkpg.com to see if we need to publish dev version of package or can use package from public NPM repostiroy
when package is queued for publishing - it checks if any other gatsby package depend on it and add them to publishing queue (i.e. dependency change in gatsby-plugin-page-creator will cause gatsby package to be published as well)
once final list of packages to be published is done, it start publishing process:
- if there are any packages that need to be published, it starts temporary verdaccio server:
  - server is configured to:
    - allow anonymous publishes (so user don't have to login to that local registry)
    - set up storage that is set to be gatsby-dev-cli/verdaccio
  - everytime server starts it has clean slate (it clears its storage
- it temporarily add .npmrc to package to allow using npm publish without being logged in to that local npm repository ( see Is anonymous publishing allowed? verdaccio/verdaccio#212 (comment) - this comment was made almost 2 years ago - right now yarn also require to be logged in). This tricks npm to think it's logged in by applying dummy access token
- it temporarirly edit package.json and adjust package version and version selector for any dependencies that are in packages to be published list (this is needed for deps of deps to install correctly)
- it publishes that package to local registry with gatsby-dev dist-tag
- it reverts package.json changes and removes temporary .npmrc file
- it installs modified "top-level" packages (so if you changed gatsby-cli - it will run yarn add gatsby@gatsby-dev
  - because we adjusted version selectors - this will correctly install modified gatsby-cli@gatsby-dev too
  - potential issue - this changes package.json/yarn.lock in local site - I potentially could restore it, but I think this would cause more troubles because yarn uses those files as source of truth, so leaving it modified seems like better option

Limitations:

right now it only handle dependency changes on initial scan and doesn't work later on (it will output notices to terminal, but because gatsby-dev-cli is "fire-and-forget" it's unlikely that people will see them quickly. This is potentially solvable but would add more work and delay this.

Changes:

Copying files for initial scan is postponed to after ready event is emitted and (if any) packages are installed. That's because now it also potentially install packages from public NPM, so I need to make sure that files are copied after that step

juanpicado · 2019-02-04T15:40:46Z

packages/gatsby-dev-cli/src/verdaccio.js

+  // because version doesn't change when developing locally verdaccio wouldn't
+  // let republish package with same version - so as quick workaround we
+  // unpublish package.
+  // Ideally we could check if we need to unpublish: i.e. compare deps of


If you force publish npm publish --force the version is replaced. Perhaps that helps.

ohhh, cool, thanks for the tip! But there is another issue that will render this a bit irrelevant - let me write up follow up comment to document what I mean

pieh · 2019-02-04T16:16:15Z

My initial implementation that publish to local repository with same package version has couple of issues when handling cases of nested deps (i.e. gatsby depending on gatsby-cli, gatsby-link etc or gatsby-source-drupal depending on gatsby-source-filesystem):

When we publish modified version of nested dependency with same version, and then try to instal "top level" package yarn will be smart and don't reinstall deps of top level package (because they are installed)

So in next round what I will do is actually use lerna to publish canary version to local repository and then specifically install those canary versions in example site.

This brings some side effect of changing versions in monorepo packages so I will also need to make sure I store package.json content in memory and restore it after publishing to not introduce unwanted changes to package.json

DSchau

This is looking awesome.

In theory, as we discussed, I think we just need to persist the verdaccio storage directory (between jobs) and we can get this working from a CI perspective, as well.

DSchau · 2019-02-04T18:43:29Z

packages/gatsby-dev-cli/src/verdaccio.js

+  try {
+    await promisifiedSpawn(unpublishCmd)
+    console.log(`Unpublished ${packageName}@${version} from local registry`)
+  } catch {


Do we want to log the error here? Is there an error?

There is an error because I made promisifiedSpawn to reject with exit code if it's non-zero and unpublish command will exit with non-zero if package doesn't exist. But as mentioned above - I will actually need to scratch this code because it doesn't handle deps of deps (i.e. if I change dep in gatsby-cli and re-install gatsby package - it won't reinstall gatsby-cli - because version didn't change) - I will use lerna to publish canary release to local registry and later on install that canary - yet to fully verify, but it "should work" (TM)

I'm not sure if you publish canary 2 times in a row (with same code) it will result in same "hash" or not - TBD

packages/gatsby-cli/package.json

packages/gatsby-dev-cli/src/local-npm-registry/check-deps-changes.js

pieh · 2019-03-21T02:47:58Z

packages/gatsby-dev-cli/src/local-npm-registry/verdaccio.js

+
+  // TO-DO install packages locally
+  // need to install intersection of `packagesToPublish` and `packages`
+  // (packages filtered out will be deps of packages to install)


this will cause changes to package.json and yarn.lock in local site (yarn doesn't support --no-save - yarnpkg/yarn#1743). I tend to lean toward documenting this behaviour instead of hacking things (storing content of those files and restoring it after installation) as this could cause some weirdness with yarn as it does use those files as source of truth

sidharthachatterjee · 2019-03-28T16:39:33Z

packages/gatsby-cli/src/reporter/index.js

@@ -22,6 +23,9 @@ type ActivityArgs = {
 */

 module.exports = Object.assign(reporter, {
+  cat() {
+    console.log(showMeARandomASCIICat())


Can we please not remove this? 😛

using cat-me was a mistake 😂

wardpeet

Almost ready to be shipped! 👍 This looks great the signalExit works too!

packages/gatsby-dev-cli/src/utils/__tests__/traverse-package-deps.js

packages/gatsby-dev-cli/src/utils/get-dependant-packages.js

…blish

wardpeet

I say ship it! Looks perfect to me!

wardpeet · 2019-04-02T04:40:23Z

@pieh mind removing the cat stuff so we can ship this? 😸

sidharthachatterjee · 2019-04-02T16:34:19Z

packages/gatsby-dev-cli/src/utils/check-deps-changes.js

+
+    // this allow us to not publish to local repository
+    // and save some time/work
+    try {


This is great!

sidharthachatterjee · 2019-04-02T16:35:46Z

packages/gatsby-dev-cli/src/utils/check-deps-changes.js

+      localPKGjson.dependencies
+    )
+
+    const diff2 = difference(


This is awesome 😄

sidharthachatterjee

This looks incredible. So glad to see this come in! 🎉

We need to update the README but I think we can do that in a follow up PR.

KyleAMathews · 2019-04-02T20:29:56Z

💥awesome work @pieh! This has been a TODO nearly forever :-D Will be huge help

* docs(gatsby-source-shopify): Add note about API permissions (#13037) Note which permissions you should enable on the Shopify Storefront API. Without these permissions you'll get a fairly cryptic error message. * chore(docs): match the Wording Style of Other Tutorial Parts (#13034) * chore(docs): fix typo in convincing others doc (#13033)  ## Description Fixes a misspelled word. * fix(docs): expand guidelist on partnering with gatsby page (#13029) Following up on #12970. Current https://www.gatsbyjs.org/docs/partnering-with-gatsby/: ![image](https://user-images.githubusercontent.com/21834/55404445-2f445080-5558-11e9-84d8-f75db8dd7297.png) * fix(starters): update gatsby monorepo (#12925) This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | gatsby | dependencies | patch | [`^2.3.3` -> `^2.3.5`](https://diff.intrinsic.com/gatsby/2.3.3/2.3.5) | [source](https://togithub.com/gatsbyjs/gatsby) | | gatsby-image | dependencies | patch | [`^2.0.35` -> `^2.0.37`](https://diff.intrinsic.com/gatsby-image/2.0.35/2.0.37) | [source](https://togithub.com/gatsbyjs/gatsby) | | gatsby-plugin-manifest | dependencies | patch | [`^2.0.25` -> `^2.0.26`](https://diff.intrinsic.com/gatsby-plugin-manifest/2.0.25/2.0.26) | [source](https://togithub.com/gatsbyjs/gatsby) | --- ### Release Notes <details> <summary>gatsbyjs/gatsby</summary> ### [`v2.3.5`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5) [Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5) ### [`v2.3.4`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4) [Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/config-help/issues) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#gatsbyjs/gatsby). * feat(blog): add gatsby is great blog post (#12777) * chore: add blog post * chore: keep iterating * chore: more tweaks * feat: nearly finish up * chore: run tinypng * chore: fix some typos * chore: fix snippet * chore: add a gif, it gets the people going * chore: more * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * chore: change date * chore: tighten up last section * chore: change data * chore: update per feedback * chore(docs): replace absolute links with relative links (#12949)  ## Description Suggest a more complete structure to the example gatsby-config.js file ## Related Issues Along with #12103 this PR fixes #11957  * chore(showcase): Add Assortment to site showcase (#13002) ## Description Adding [assortment.io](https://assortment.io) to site showcase. Assortment is my Web Development blog that I've recently updated to Gatsby, Netlify, Netlify CMS and Emotion. It'd be cool to see it on the showcase 😃 * feat(gatsby-dev-cli): add verdaccio support (#11525) * feat(gatsby-dev-cli): add verdaccio support [wip] * yuck - don't look * just to verify verdaccio * fix gitignore and add htpasswd with dummy gatsby-dev user * some logging to understand why it tries to handle all the packages * just temporarily so it hopefully at least works * moar data * don't copy all the packages right now * don't rely on package name starting with "gatsby" heuristic * tmp commit * tmp * fs change * tmp * a * updates * remove random files that shouldn't be here * tmp * revert dep changes * ignore changes to package.json created during publishing * testing of dep change in gatsby-cli is picked up by gatsby-dev-cli * let's see if gatsby-dev will handle case of no node_modules * sanity check * adjust console message * add missing devDeps * more missing devDeps * grab package.json from unpkg if package is not yet installed locally * correctly ignore package.json changes during publishing * cleaning things up * htpasswd loc * restore gatsby package.json * adjust ignore files * gatsby-dev-cli: ignore tests * remove extra ln * less console output * turns out you don't need htpasswd after all * use exact when installing local packages - timestamp is used in version * why it failed? * use yarn for publishing - see verdaccio/verdaccio#997 * v0.1.1 * add temporary .npmrc file to allow anonymous publishes * add some jsdocs * update yarn.lock * oops * debug why still can't publish anon * adjust npmrc content * doh * Revert "debug why still can't publish anon" This reverts commit fc1045a. * handle package installation of deps didn't change * skip version changes for packages in gatsby mono-repo, queue copying instead of doing it immediately * fix tests * packages stored in verdaccio storage seems to be picked up by jest and causing trouble, so let's ignore verdaccio storage directory * bye "wat", you will be missed * bail early to avoid conditional bracket hell * more bailing early * more concise * new line * use exaca to simplify running yarn * clean up www/.gitignore * handle not existing packages * remove unused (was needed for basic auth) * cleanup temp file changes when process exit in middle of publishing * ops * Apply suggestions from code review Co-Authored-By: pieh <misiek.piechowiak@gmail.com> * cleanup unpkg response handler * move stuff around * remove tmp comment * document traversePackageDocs fn * restrcuture files * add basic tests for traversingPackageDeps * add basic tests for generating packages to publish (based on dep graph) * fix tests on windows * handle circular dependencies when constructing list of packages to publish * remove cat ;( * restore original e2e-test script * update gitignore * chore(release): Publish - babel-plugin-remove-graphql-queries@2.6.3 - babel-preset-gatsby@0.1.11 - gatsby-dev-cli@2.4.13 - gatsby-plugin-typescript@2.0.12 - gatsby-source-shopify@2.0.23 - gatsby@2.3.6 * chore(release): Publish - gatsby-dev-cli@2.4.14 * docs(gatsby-dev-cli): Edit README (#13049) * Build out Gatsby media information in docs (#12906) * add video info, delete unnecessary stubs Related to #12903 * fix internal link for html5 video section * update videoTitle example Co-Authored-By: marcysutton <holla@marcysutton.com> * Apply suggestions from code review thanks for the feedback! Co-Authored-By: marcysutton <holla@marcysutton.com> * incorporate feedback, make into real docs!! * delete unused stubs * Update docs/docs/working-with-video.md Co-Authored-By: marcysutton <holla@marcysutton.com> * Update docs/docs/working-with-video.md Co-Authored-By: marcysutton <holla@marcysutton.com> * chore(gatsby): fix domready package to be compatible with ie10 (#13027) * changed domready package to domready-loaded which is compatible with ie10 * updated domready to @mikaelkristiansson/domready * updated packages/gatsby to use @mikaelkristiansson/domready * chore(release): Publish - gatsby@2.3.7 * feat(gatsby-transformer-react-docgen): use local babel config for react-docgen (#12001) * feat: use local babel config for react-docgen BREAKING CHANGE: now uses the local babel config with a fallback * Update README.md * chore(release): Publish - gatsby-transformer-react-docgen@4.0.0 * chore(docs): add “Why I used GatsbyJS (#12954) Why I used GatsbyJS  ## Description  ## Related Issues  * feat(www): don't check for overview frontmatter (#13060) Fixes `[[guidelist]]` not being replaced in few pages (i.e. in https://www.gatsbyjs.org/docs/winning-over-stakeholders/ ) The code is handling cases when there are no children (tried building locally and it worked just fine). Follow up to this would be to clear `.md` files that use `overview` and adjust page query. But this is just quick fix. * chore(docs): add starter library to docs sidebar under starters (#12963) 40% of people visiting the starters page go here next, so we should probably add this: ![image](https://user-images.githubusercontent.com/4388699/55285012-58d26180-5337-11e9-9259-68e81b4894ad.png) * chore(showcase): Add gmartinez.dev to showcase (#13067)  ## Description Adding gmartinez.dev to showcase list in site.yml  Co-authored-by: Lennart <lekoarts@gmail.com> * fix(gatsby): don't try to statically analyze gatsby-node, require it and examine exports instead (#13053) * fix: don't try to statically analyze gatsby-node, require it and examine exports instead * differentiate test names * Update packages/gatsby/src/bootstrap/resolve-module-exports.js Co-Authored-By: pieh <misiek.piechowiak@gmail.com> * chore(release): Publish - gatsby@2.3.8 * Use Loki's elemMatch operator (#13025) * feat(gatsby): add util.promisify polyfill for older node version (#13024) * refactor(gatsby): gatsby develop: cleanup port detection (#13006) * chore(release): Publish - gatsby@2.3.9 * fix(gatsby): ignore __esModule export in gatsby-node exports (#13081) I introduced bug/regression in #13053 by not removing `__esModule` export name from resolved export names - it break some plugins Fixes: #13079 * chore(release): Publish - gatsby@2.3.10 * fix(www): Hubspot form UI (#13080) * fix(www): Work around HubSpot’s CSS being loaded …by pulling in react-hubspot-form locally, and modifying it slightly. See comment in `www/src/components/react-hubspot-form` for more info. * Fix `formInput` styles … now matching the reference homepage newsletter form — no more Futura PT for input text. * Return nothing because linter * Make into Two Words

* Fix Comma Usage * Fix Comma Usage; Misc Improvements (#13038) * Fix Misuse of Commas, Et Al (#13039) Use em dash in place of two hyphens. Format paragraph to be on one line (apparently the convention). * Fix Comma Usage and Do Some Misc Changes (#13040) * Fix Comma Usage and Do Some Misc Changes Do code formatting to match rest of file. Use em dash instead of two hyphens. Etc. * Update HTML Entity * Add Hyphen for Clarity (#13042) * Fix Comma Usage in Blog (#13085) * docs(gatsby-source-shopify): Add note about API permissions (#13037) Note which permissions you should enable on the Shopify Storefront API. Without these permissions you'll get a fairly cryptic error message. * chore(docs): match the Wording Style of Other Tutorial Parts (#13034) * chore(docs): fix typo in convincing others doc (#13033)  ## Description Fixes a misspelled word. * fix(docs): expand guidelist on partnering with gatsby page (#13029) Following up on #12970. Current https://www.gatsbyjs.org/docs/partnering-with-gatsby/: ![image](https://user-images.githubusercontent.com/21834/55404445-2f445080-5558-11e9-84d8-f75db8dd7297.png) * fix(starters): update gatsby monorepo (#12925) This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | gatsby | dependencies | patch | [`^2.3.3` -> `^2.3.5`](https://diff.intrinsic.com/gatsby/2.3.3/2.3.5) | [source](https://togithub.com/gatsbyjs/gatsby) | | gatsby-image | dependencies | patch | [`^2.0.35` -> `^2.0.37`](https://diff.intrinsic.com/gatsby-image/2.0.35/2.0.37) | [source](https://togithub.com/gatsbyjs/gatsby) | | gatsby-plugin-manifest | dependencies | patch | [`^2.0.25` -> `^2.0.26`](https://diff.intrinsic.com/gatsby-plugin-manifest/2.0.25/2.0.26) | [source](https://togithub.com/gatsbyjs/gatsby) | --- ### Release Notes <details> <summary>gatsbyjs/gatsby</summary> ### [`v2.3.5`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5) [Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5) ### [`v2.3.4`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4) [Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/config-help/issues) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#gatsbyjs/gatsby). * feat(blog): add gatsby is great blog post (#12777) * chore: add blog post * chore: keep iterating * chore: more tweaks * feat: nearly finish up * chore: run tinypng * chore: fix some typos * chore: fix snippet * chore: add a gif, it gets the people going * chore: more * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * chore: change date * chore: tighten up last section * chore: change data * chore: update per feedback * chore(docs): replace absolute links with relative links (#12949)  ## Description Suggest a more complete structure to the example gatsby-config.js file ## Related Issues Along with #12103 this PR fixes #11957  * chore(showcase): Add Assortment to site showcase (#13002) ## Description Adding [assortment.io](https://assortment.io) to site showcase. Assortment is my Web Development blog that I've recently updated to Gatsby, Netlify, Netlify CMS and Emotion. It'd be cool to see it on the showcase 😃 * Fix Comma Usage; Misc Updates * Make into Two Words (#13084) * docs(gatsby-source-shopify): Add note about API permissions (#13037) Note which permissions you should enable on the Shopify Storefront API. Without these permissions you'll get a fairly cryptic error message. * chore(docs): match the Wording Style of Other Tutorial Parts (#13034) * chore(docs): fix typo in convincing others doc (#13033)  ## Description Fixes a misspelled word. * fix(docs): expand guidelist on partnering with gatsby page (#13029) Following up on #12970. Current https://www.gatsbyjs.org/docs/partnering-with-gatsby/: ![image](https://user-images.githubusercontent.com/21834/55404445-2f445080-5558-11e9-84d8-f75db8dd7297.png) * fix(starters): update gatsby monorepo (#12925) This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | gatsby | dependencies | patch | [`^2.3.3` -> `^2.3.5`](https://diff.intrinsic.com/gatsby/2.3.3/2.3.5) | [source](https://togithub.com/gatsbyjs/gatsby) | | gatsby-image | dependencies | patch | [`^2.0.35` -> `^2.0.37`](https://diff.intrinsic.com/gatsby-image/2.0.35/2.0.37) | [source](https://togithub.com/gatsbyjs/gatsby) | | gatsby-plugin-manifest | dependencies | patch | [`^2.0.25` -> `^2.0.26`](https://diff.intrinsic.com/gatsby-plugin-manifest/2.0.25/2.0.26) | [source](https://togithub.com/gatsbyjs/gatsby) | --- ### Release Notes <details> <summary>gatsbyjs/gatsby</summary> ### [`v2.3.5`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5) [Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.4...gatsby@2.3.5) ### [`v2.3.4`](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4) [Compare Source](https://togithub.com/gatsbyjs/gatsby/compare/gatsby@2.3.3...gatsby@2.3.4) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`". :ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/config-help/issues) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#gatsbyjs/gatsby). * feat(blog): add gatsby is great blog post (#12777) * chore: add blog post * chore: keep iterating * chore: more tweaks * feat: nearly finish up * chore: run tinypng * chore: fix some typos * chore: fix snippet * chore: add a gif, it gets the people going * chore: more * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-25-behind-the-scenes-what-makes-gatsby-great/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * chore: change date * chore: tighten up last section * chore: change data * chore: update per feedback * chore(docs): replace absolute links with relative links (#12949)  ## Description Suggest a more complete structure to the example gatsby-config.js file ## Related Issues Along with #12103 this PR fixes #11957  * chore(showcase): Add Assortment to site showcase (#13002) ## Description Adding [assortment.io](https://assortment.io) to site showcase. Assortment is my Web Development blog that I've recently updated to Gatsby, Netlify, Netlify CMS and Emotion. It'd be cool to see it on the showcase 😃 * feat(gatsby-dev-cli): add verdaccio support (#11525) * feat(gatsby-dev-cli): add verdaccio support [wip] * yuck - don't look * just to verify verdaccio * fix gitignore and add htpasswd with dummy gatsby-dev user * some logging to understand why it tries to handle all the packages * just temporarily so it hopefully at least works * moar data * don't copy all the packages right now * don't rely on package name starting with "gatsby" heuristic * tmp commit * tmp * fs change * tmp * a * updates * remove random files that shouldn't be here * tmp * revert dep changes * ignore changes to package.json created during publishing * testing of dep change in gatsby-cli is picked up by gatsby-dev-cli * let's see if gatsby-dev will handle case of no node_modules * sanity check * adjust console message * add missing devDeps * more missing devDeps * grab package.json from unpkg if package is not yet installed locally * correctly ignore package.json changes during publishing * cleaning things up * htpasswd loc * restore gatsby package.json * adjust ignore files * gatsby-dev-cli: ignore tests * remove extra ln * less console output * turns out you don't need htpasswd after all * use exact when installing local packages - timestamp is used in version * why it failed? * use yarn for publishing - see verdaccio/verdaccio#997 * v0.1.1 * add temporary .npmrc file to allow anonymous publishes * add some jsdocs * update yarn.lock * oops * debug why still can't publish anon * adjust npmrc content * doh * Revert "debug why still can't publish anon" This reverts commit fc1045a. * handle package installation of deps didn't change * skip version changes for packages in gatsby mono-repo, queue copying instead of doing it immediately * fix tests * packages stored in verdaccio storage seems to be picked up by jest and causing trouble, so let's ignore verdaccio storage directory * bye "wat", you will be missed * bail early to avoid conditional bracket hell * more bailing early * more concise * new line * use exaca to simplify running yarn * clean up www/.gitignore * handle not existing packages * remove unused (was needed for basic auth) * cleanup temp file changes when process exit in middle of publishing * ops * Apply suggestions from code review Co-Authored-By: pieh <misiek.piechowiak@gmail.com> * cleanup unpkg response handler * move stuff around * remove tmp comment * document traversePackageDocs fn * restrcuture files * add basic tests for traversingPackageDeps * add basic tests for generating packages to publish (based on dep graph) * fix tests on windows * handle circular dependencies when constructing list of packages to publish * remove cat ;( * restore original e2e-test script * update gitignore * chore(release): Publish - babel-plugin-remove-graphql-queries@2.6.3 - babel-preset-gatsby@0.1.11 - gatsby-dev-cli@2.4.13 - gatsby-plugin-typescript@2.0.12 - gatsby-source-shopify@2.0.23 - gatsby@2.3.6 * chore(release): Publish - gatsby-dev-cli@2.4.14 * docs(gatsby-dev-cli): Edit README (#13049) * Build out Gatsby media information in docs (#12906) * add video info, delete unnecessary stubs Related to #12903 * fix internal link for html5 video section * update videoTitle example Co-Authored-By: marcysutton <holla@marcysutton.com> * Apply suggestions from code review thanks for the feedback! Co-Authored-By: marcysutton <holla@marcysutton.com> * incorporate feedback, make into real docs!! * delete unused stubs * Update docs/docs/working-with-video.md Co-Authored-By: marcysutton <holla@marcysutton.com> * Update docs/docs/working-with-video.md Co-Authored-By: marcysutton <holla@marcysutton.com> * chore(gatsby): fix domready package to be compatible with ie10 (#13027) * changed domready package to domready-loaded which is compatible with ie10 * updated domready to @mikaelkristiansson/domready * updated packages/gatsby to use @mikaelkristiansson/domready * chore(release): Publish - gatsby@2.3.7 * feat(gatsby-transformer-react-docgen): use local babel config for react-docgen (#12001) * feat: use local babel config for react-docgen BREAKING CHANGE: now uses the local babel config with a fallback * Update README.md * chore(release): Publish - gatsby-transformer-react-docgen@4.0.0 * chore(docs): add “Why I used GatsbyJS (#12954) Why I used GatsbyJS  ## Description  ## Related Issues  * feat(www): don't check for overview frontmatter (#13060) Fixes `[[guidelist]]` not being replaced in few pages (i.e. in https://www.gatsbyjs.org/docs/winning-over-stakeholders/ ) The code is handling cases when there are no children (tried building locally and it worked just fine). Follow up to this would be to clear `.md` files that use `overview` and adjust page query. But this is just quick fix. * chore(docs): add starter library to docs sidebar under starters (#12963) 40% of people visiting the starters page go here next, so we should probably add this: ![image](https://user-images.githubusercontent.com/4388699/55285012-58d26180-5337-11e9-9259-68e81b4894ad.png) * chore(showcase): Add gmartinez.dev to showcase (#13067)  ## Description Adding gmartinez.dev to showcase list in site.yml  Co-authored-by: Lennart <lekoarts@gmail.com> * fix(gatsby): don't try to statically analyze gatsby-node, require it and examine exports instead (#13053) * fix: don't try to statically analyze gatsby-node, require it and examine exports instead * differentiate test names * Update packages/gatsby/src/bootstrap/resolve-module-exports.js Co-Authored-By: pieh <misiek.piechowiak@gmail.com> * chore(release): Publish - gatsby@2.3.8 * Use Loki's elemMatch operator (#13025) * feat(gatsby): add util.promisify polyfill for older node version (#13024) * refactor(gatsby): gatsby develop: cleanup port detection (#13006) * chore(release): Publish - gatsby@2.3.9 * fix(gatsby): ignore __esModule export in gatsby-node exports (#13081) I introduced bug/regression in #13053 by not removing `__esModule` export name from resolved export names - it break some plugins Fixes: #13079 * chore(release): Publish - gatsby@2.3.10 * fix(www): Hubspot form UI (#13080) * fix(www): Work around HubSpot’s CSS being loaded …by pulling in react-hubspot-form locally, and modifying it slightly. See comment in `www/src/components/react-hubspot-form` for more info. * Fix `formInput` styles … now matching the reference homepage newsletter form — no more Futura PT for input text. * Return nothing because linter * Make into Two Words * Fix Comma Usage; Misc Updates (#13090) Hopefully fix a code formatting issue when in a highlighted section. * Fix Comma Usage; Misc Update (#13103) * chore: format

pieh added 4 commits February 3, 2019 17:50

feat(gatsby-dev-cli): add verdaccio support [wip]

4e587ba

yuck - don't look

3e2d0d5

just to verify verdaccio

e5c179c

fix gitignore and add htpasswd with dummy gatsby-dev user

641a91c

pieh added the status: WIP label Feb 3, 2019

pieh requested a review from a team as a code owner February 3, 2019 16:59

pieh added 5 commits February 3, 2019 18:14

some logging to understand why it tries to handle all the packages

6f555ab

just temporarily so it hopefully at least works

41d9583

moar data

c69e1f7

don't copy all the packages right now

571a8ae

don't rely on package name starting with "gatsby" heuristic

408aeca

juanpicado reviewed Feb 4, 2019

View reviewed changes

pieh added 2 commits February 4, 2019 18:10

tmp commit

d1ec15b

tmp

af89ec5

DSchau reviewed Feb 4, 2019

View reviewed changes

pieh added 6 commits February 4, 2019 20:10

fs change

4de0f3a

Merge remote-tracking branch 'origin/master' into dev-verdaccio

d51ac61

tmp

be2e6c1

a

eca2644

updates

229f02c

remove random files that shouldn't be here

f9edc11

pieh force-pushed the dev-verdaccio branch from 57b8875 to f9edc11 Compare March 21, 2019 02:42

pieh requested a review from a team as a code owner March 21, 2019 02:42

pieh commented Mar 21, 2019

View reviewed changes

packages/gatsby-cli/package.json Outdated Show resolved Hide resolved

pieh commented Mar 21, 2019

View reviewed changes

packages/gatsby-dev-cli/src/local-npm-registry/check-deps-changes.js Outdated Show resolved Hide resolved

pieh commented Mar 21, 2019

View reviewed changes

pieh mentioned this pull request Mar 21, 2019

chore(*): Remove CSS false positives - Use newer JSDom version #12719

Merged

pieh added 2 commits March 21, 2019 13:48

tmp

9018f6d

revert dep changes

071bc16

pieh added 3 commits March 28, 2019 16:01

restrcuture files

7e66caf

add basic tests for traversingPackageDeps

a962399

add basic tests for generating packages to publish (based on dep graph)

5002629

sidharthachatterjee reviewed Mar 28, 2019

View reviewed changes

pieh added 2 commits March 29, 2019 02:51

fix tests on windows

c8578cd

Merge remote-tracking branch 'upstream/master' into dev-verdaccio

64c7870

wardpeet suggested changes Mar 29, 2019

View reviewed changes

packages/gatsby-dev-cli/src/utils/__tests__/traverse-package-deps.js Show resolved Hide resolved

packages/gatsby-dev-cli/src/utils/get-dependant-packages.js Show resolved Hide resolved

wardpeet added status: awaiting author response Additional information has been requested from the author and removed status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response labels Mar 29, 2019

handle circular dependencies when constructing list of packages to pu…

cde13fb

…blish

wardpeet approved these changes Mar 29, 2019

View reviewed changes

pieh added 4 commits April 2, 2019 13:17

Merge remote-tracking branch 'origin/master' into dev-verdaccio

3960fa9

remove cat ;(

65e040e

restore original e2e-test script

14ea6c8

update gitignore

d11552a

sidharthachatterjee removed the status: awaiting author response Additional information has been requested from the author label Apr 2, 2019

sidharthachatterjee self-requested a review April 2, 2019 16:23

sidharthachatterjee reviewed Apr 2, 2019

View reviewed changes

sidharthachatterjee self-requested a review April 2, 2019 16:42

sidharthachatterjee approved these changes Apr 2, 2019

View reviewed changes

sidharthachatterjee merged commit a4f7e77 into gatsbyjs:master Apr 2, 2019

pieh deleted the dev-verdaccio branch April 2, 2019 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(gatsby-dev-cli): add verdaccio support #11525

feat(gatsby-dev-cli): add verdaccio support #11525

pieh commented Feb 3, 2019 •

edited

Loading

juanpicado Feb 4, 2019

pieh Feb 4, 2019

pieh commented Feb 4, 2019

DSchau left a comment

DSchau Feb 4, 2019

pieh Feb 4, 2019

pieh Feb 4, 2019

pieh Mar 21, 2019

sidharthachatterjee Mar 28, 2019

pieh Mar 29, 2019

wardpeet left a comment

wardpeet left a comment

wardpeet commented Apr 2, 2019

sidharthachatterjee Apr 2, 2019

sidharthachatterjee Apr 2, 2019

sidharthachatterjee left a comment

KyleAMathews commented Apr 2, 2019

feat(gatsby-dev-cli): add verdaccio support #11525

feat(gatsby-dev-cli): add verdaccio support #11525

Conversation

pieh commented Feb 3, 2019 • edited Loading

Goals:

The way it works:

Limitations:

Changes:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pieh commented Feb 4, 2019

DSchau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wardpeet left a comment

Choose a reason for hiding this comment

wardpeet left a comment

Choose a reason for hiding this comment

wardpeet commented Apr 2, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sidharthachatterjee left a comment

Choose a reason for hiding this comment

KyleAMathews commented Apr 2, 2019

pieh commented Feb 3, 2019 •

edited

Loading