feat(gatsby): allow schema customization #11480
Conversation
|
My next plans:
Longer term stuff / nice to haves
|
| type: `String!`, | ||
| }) | ||
| }) | ||
| InternalTC.getITC() |
There was a problem hiding this comment.
Probably not needed now that we use toInputObjectType directly (same with NodeInterface.getITC()) - We called this here to register a non-prefixed name (Nodenput and not MarkdownParentNodeInput - but we should try to remove prefixing upstream)
There was a problem hiding this comment.
What do you mean by "remove prefixing upstream"?
There was a problem hiding this comment.
Just not adding the type name here
There was a problem hiding this comment.
One thing I was thinking about is introducing concept of a "TypeSetComposer" which is an abstraction on top of TypeComporers, InputTypeComposers etc and allows defining dependencies and transformations. Eg we can then write own getITC that knows how to not prefix. This would also solve the issue with clearing the ITC cache.
There was a problem hiding this comment.
I'll have to think a bit about this, but not sure if we need to do much more than we already have: can we just call tc.removeInputTypeComposer(); tc.getITC() here? What other issues would TypeSetComposer address?
There was a problem hiding this comment.
I thought it might also have all the other type composers linked, like filter, sort etc. So we could clear all the generated types in one go when original type changes. Could be useful for things like live schema reload.
* chore(blog): add schema customization blog post release * chore: tweak first sentence * Update docs/blog/2019-03-18-releasing-new-schema-customization/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-18-releasing-new-schema-customization/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-18-releasing-new-schema-customization/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-18-releasing-new-schema-customization/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-18-releasing-new-schema-customization/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * Update docs/blog/2019-03-18-releasing-new-schema-customization/index.md Co-Authored-By: DSchau <DSchau@users.noreply.github.com> * chore: address feedback * Update docs/blog/2019-03-18-releasing-new-schema-customization/index.md
docs/blog/2019-03-18-releasing-new-schema-customization/index.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: freiksenet <freiksenet@gmail.com>
docs/blog/2019-03-18-releasing-new-schema-customization/index.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: freiksenet <freiksenet@gmail.com>
* Ignore empty strings in example value creation
This reverts commit 09f0d91.
There was a problem hiding this comment.
Awesome work on this @freiksenet and @stefanprobst! We were testing and verifying this on multiple open source sites checking if it breaks things and it looks solid right now
Rendered release blog post
Is in runnable state right now. Try it:
Report all bugs in #12272.
Description
Related Issues