[1.0] Fix onRouteUpdate API #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit ca3c821 |
|
Deploy preview ready! Built with commit ca3c821 |
|
Deploy preview ready! Built with commit ca3c821 |
|
Looks great! Thanks for diagnosing and fixing the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the analytics plugin is broken. It isn't sending any page views other then initial page load. Upon further investigation I found that this is because the onRouteUpdate API is broken.
It turns out that a listener is attached to a history instance, but the history object passed in from
routeProps.historyon render is used to set window.___history which is used by other code, and apparently this is not the same history instance.I am not entirely clear where this
routeProps.historycomes from, but attaching the listener to that instance seems to have fixed the API.In addition I did some renaming from
$()=>createInstance()because I think it makes the code more readable.