Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-jest #10913

Closed
wants to merge 2 commits into from
Closed

Conversation

stefanprobst
Copy link
Contributor

#7872 updated jest to 23.5, but kept babel-jest at 22.4.3

@stefanprobst
Copy link
Contributor Author

Hmm, this breaks linting horribly. Needs investigation - seems ok as long as yarn.lock is not removed.

@stefanprobst
Copy link
Contributor Author

stefanprobst commented Jan 8, 2019

Ok because of prettier 1.14 => 1.15. Should 1.14 be pinned?

@stefanprobst stefanprobst reopened this Jan 8, 2019
@pieh
Copy link
Contributor

pieh commented Jan 8, 2019

Ok because of prettier 1.14 => 1.15. Should 1.14 be pinned?

we hopefully will upgrade soonish to 1.15 - there is PR open for quite some time that does that, we just don't have nice tooling to support all currently open PRs which are against master that uses 1.14 (there will be false positives/negatives from lint CI check after upgrade)

@stefanprobst
Copy link
Contributor Author

Fixed by #11293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants