-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: create the building-a-blog stub article #10748
Conversation
This is the first draft of this article.
I didn't find the "Use cases with Gatsby" section. |
Hi @vojoup! Thanks for volunteering to write this! The section "Use cases with Gatsby" does need to be created, thanks for noticing that! |
Change the wording according to @shannonbux comment. Link now leads to the 'Using starters' section of the main tutorial.
So where should this article be placed? 🙂 |
Thanks @vojoup! This link shows where the section and article should go 0aade74?diff=unified. Right above "Adding website functionality." You only need to add this one article in the section--ignore the other stub articles! |
Is this the right place? 🙂 |
Hi @vojoup, no, it should look like this // add this section
- title: Use cases with Gatsby (including apps)
link: /docs/building-apps-with-gatsby/
items:
- title: Building a blog
link: /docs/building-a-blog/
// end of new section
- title: Adding website functionality
link: /docs/adding-website-functionality/ |
Sorry got a bid confused there plus it's getting late here... 😀 |
And moving the article there
Hello @shannonbux, I see that something is wrong with the build and that it's somehow related to these files: |
alright @vojoup! I fixed a couple small issues. This is good from a docs perspective. Just waiting for a technical review now. |
@shannonbux thank you very much!🙂 |
Looks like my edits still didn't fix it; it seems to be a linting error.
@pieh can help I think!
…On Fri, Jan 4, 2019 at 8:30 AM Vojta Oupicky ***@***.***> wrote:
@shannonbux <https://github.com/shannonbux> thank you very much!🙂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10748 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ae9o2sCyJfjXXPg87-tbvqLPQQSyVtgjks5u_4GmgaJpZM4Zl5mS>
.
|
@pieh does this need a code owner review? |
Hello @shannonbux , @pieh, is there anything needed from me? |
@pieh, @shannonbux Can I help any further ? |
My personal vote is for closing this, now that we've gotten rid of the use-cases section, it doesn't really fit in the flow anymore. I'm going to close this for now, although if we ever have a dedicated section with eg ecommerce somewhere else in the docs, we could re-open. Thanks for the work and sorry @vojoup |
This PR closes #[10447] by creating the 'Building a blog' article.