fix(gatsby-plugin-gatsby-cloud): Always create redirects.json (#32845)

* Always generate a redirects file in case a user removes all redirects

* Update packages/gatsby-plugin-gatsby-cloud/src/create-redirects.js

Co-authored-by: Ward Peeters <ward@coding-tech.com>

Co-authored-by: Sidhartha Chatterjee <me@sidharthachatterjee.com>
Co-authored-by: Ward Peeters <ward@coding-tech.com>

packages/gatsby-plugin-gatsby-cloud/src/__tests__/__snapshots__/create-redirects.js.snap

@@ -2,4 +2,6 @@
 
 exports[`create-redirects should assemble a redirects file 1`] = `"{\\"redirects\\":[{\\"fromPath\\":\\"/old-url\\",\\"toPath\\":\\"/new-url\\",\\"isPermanent\\":true},{\\"fromPath\\":\\"/url_that_is/not_pretty\\",\\"toPath\\":\\"/pretty/url\\",\\"statusCode\\":201}],\\"rewrites\\":[{\\"fromPath\\":\\"/url_that_is/ugly\\",\\"toPath\\":\\"/not_ugly/url\\"},{\\"fromPath\\":\\"/path2/*splatparam\\",\\"toPath\\":\\"/path2/[...splatparam]/\\"},{\\"fromPath\\":\\"/path/*\\",\\"toPath\\":\\"/path/[...]/\\"},{\\"fromPath\\":\\"/path3/:level1/:level2\\",\\"toPath\\":\\"/path3/[level1]/[level2]/\\"},{\\"fromPath\\":\\"/path4/:param1\\",\\"toPath\\":\\"/path4/[param1]/\\"}]}"`;
 
+exports[`create-redirects should assemble a redirects file even if there are no redirects 1`] = `"{\\"redirects\\":[],\\"rewrites\\":[]}"`;
+
 exports[`create-redirects should remove pathPrefix from redirects 1`] = `"{\\"redirects\\":[{\\"fromPath\\":\\"/old-url\\",\\"toPath\\":\\"/new-url\\",\\"isPermanent\\":true},{\\"fromPath\\":\\"/url_that_is/not_pretty\\",\\"toPath\\":\\"/pretty/url\\",\\"statusCode\\":201}],\\"rewrites\\":[]}"`;

packages/gatsby-plugin-gatsby-cloud/src/__tests__/create-redirects.js

@@ -12,12 +12,7 @@ jest.mock(`fs-extra`, () => {
 })
 
 describe(`create-redirects`, () => {
-  let reporter
-
   beforeEach(() => {
-    reporter = {
-      warn: jest.fn(),
-    }
     fs.existsSync.mockClear()
     fs.existsSync.mockReturnValue(true)
   })
@@ -165,6 +160,17 @@ describe(`create-redirects`, () => {
     }
   }
 
+  it(`should assemble a redirects file even if there are no redirects`, async () => {
+    const pluginData = await createPluginData()
+    await createRedirects(pluginData, [], [])
+
+    const output = await fs.readFile(
+      pluginData.publicFolder(REDIRECTS_FILENAME),
+      `utf8`
+    )
+    expect(output).toMatchSnapshot()
+  })
+
   it(`should assemble a redirects file`, async () => {
     const pluginData = await createPluginData()
 

packages/gatsby-plugin-gatsby-cloud/src/create-redirects.js

@@ -4,13 +4,10 @@ import { REDIRECTS_FILENAME } from "./constants"
 export default async function writeRedirectsFile(
   pluginData,
   redirects,
-  rewrites,
-  pathPrefix
+  rewrites
 ) {
   const { publicFolder } = pluginData
 
-  if (!redirects.length && !rewrites.length) return null
-
   // gatsby adds path-prefix to redirects so we need to remove them again
   if (redirects && pluginData.pathPrefix) {
     redirects = redirects.map(redirect => {