fix(gatsby-plugin-google-gtag): correct script to match google's curr…

…ent (#36993) Co-authored-by: Lennart <lekoarts@gmail.com>
gatsbyjs · Nov 17, 2022 · 5cb5014 · 5cb5014
1 parent 644c84b
commit 5cb5014
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/docs/docs/reference/built-in-components/gatsby-script.md b/docs/docs/reference/built-in-components/gatsby-script.md
@@ -153,9 +153,9 @@ import { Script } from "gatsby"
 />
 <Script id="gtag-config" strategy="off-main-thread" forward={[`gtag`]}>
   {`
-    window.dataLayer = window.dataLayer || []
-    window.gtag = function gtag() { window.dataLayer.push(arguments) }
-    gtag('js', new Date())
+    window.dataLayer = window.dataLayer || [];
+    function gtag(){dataLayer.push(arguments)};
+    gtag('js', new Date());
     gtag('config', ${process.env.GTAG}, { page_path: location ? location.pathname + location.search + location.hash : undefined })
   `}
 </Script>

diff --git a/packages/gatsby-plugin-google-gtag/src/gatsby-ssr.js b/packages/gatsby-plugin-google-gtag/src/gatsby-ssr.js
@@ -59,7 +59,7 @@ exports.onRenderBody = (
           : `true`
       }) {
         window.dataLayer = window.dataLayer || [];
-        function gtag(){window.dataLayer && window.dataLayer.push(arguments);}
+        function gtag(){dataLayer.push(arguments);}
         gtag('js', new Date());
 
         ${pluginOptions.trackingIds

diff --git a/packages/gatsby-script/README.md b/packages/gatsby-script/README.md
@@ -37,8 +37,8 @@ function IndexPage() {
         {`
           // Example configuration of Google Analytics for use in Partytown
           window.dataLayer = window.dataLayer || [];
-          window.gtag = function gtag() { window.dataLayer.push(arguments); }
-          gtag('js', new Date()); 
+          function gtag(){dataLayer.push(arguments)};
+          gtag('js', new Date());
           gtag('config', ${GTM}, { send_page_view: false })
         `}
       </Script>