fix(gatsby): fix onCreatePage typings (#20871)

gatsbyjs · Jan 31, 2020 · 26e0cbc · 26e0cbc
1 parent 1f0793c
commit 26e0cbc
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/packages/gatsby/index.d.ts b/packages/gatsby/index.d.ts
@@ -208,8 +208,8 @@ export interface GatsbyNode {
    * See the guide [Creating and Modifying Pages](https://www.gatsbyjs.org/docs/creating-and-modifying-pages/)
    * for more on this API.
    */
-  onCreatePage?<TNode extends object = {}>(
-    args: CreatePageArgs<TNode>,
+  onCreatePage?<TContext = Record<string, unknown>>(
+    args: CreatePageArgs<TContext>,
     options?: PluginOptions,
     callback?: PluginCallback
   ): void
@@ -671,9 +671,9 @@ export interface CreateNodeArgs<TNode extends object = {}>
   }
 }
 
-export interface CreatePageArgs<TNode extends object = {}>
+export interface CreatePageArgs<TContext = Record<string, unknown>>
   extends ParentSpanPluginArgs {
-  page: Node & TNode
+  page: Page<TContext>
   traceId: string
 }
 
@@ -878,12 +878,7 @@ export interface Actions {
 
   /** @see https://www.gatsbyjs.org/docs/actions/#createPage */
   createPage<TContext = Record<string, unknown>>(
-    args: {
-      path: string
-      matchPath?: string
-      component: string
-      context: TContext
-    },
+    args: Page<TContext>,
     plugin?: ActionPlugin,
     option?: ActionOptions
   ): void
@@ -1284,3 +1279,10 @@ export interface Node extends NodeInput {
   }
   [key: string]: unknown
 }
+
+export interface Page<TContext = Record<string, unknown>> {
+  path: string
+  matchPath?: string
+  component: string
+  context: TContext
+}