Skip to content

Commit

Permalink
anolis: erofs: kill the unnecessary kunmap_atomic in erofs_read_raw_p…
Browse files Browse the repository at this point in the history
…age()

ANBZ: torvalds#511

Or unexpected behaviors could happen because erofs_put_metabuf()
already does it.

It only has bad impacts when using erofs on block devices.

Fixes: 6a5a279 ("erofs: introduce meta buffer operations")
Reviewed-by: Jeffle Xu <jefflexu@linux.alibaba.com>
Tested-by: Jeffle Xu <jefflexu@linux.alibaba.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
  • Loading branch information
hsiangkao committed Feb 21, 2022
1 parent baa4bee commit b348c22
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions fs/erofs/data.c
Original file line number Diff line number Diff line change
Expand Up @@ -371,9 +371,7 @@ static inline struct bio *erofs_read_raw_page(struct bio *bio,
memcpy(vto, vsrc + blkoff, map.m_plen);
memset(vto + map.m_plen, 0, PAGE_SIZE - map.m_plen);
kunmap_atomic(vto);
kunmap_atomic(vsrc);
flush_dcache_page(page);

SetPageUptodate(page);

erofs_put_metabuf(&buf);
Expand Down

0 comments on commit b348c22

Please sign in to comment.