Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Makefile by combining all build targets for different platforms into a single target #80

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Apr 8, 2024

Ticket(s)

N/A

Description

This PR will improve the Makefile by combining all the build targets for different platforms into a single target. This target, build-platform, can be copied for other plugins as well. Also, the version info will be injected into the binary on build.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

@mostafa mostafa merged commit 05883f3 into main Apr 8, 2024
2 checks passed
@mostafa mostafa deleted the improve-makefile branch April 8, 2024 19:34
mostafa added a commit that referenced this pull request Apr 8, 2024
mostafa added a commit that referenced this pull request Apr 8, 2024
mostafa added a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant