This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Stop using vendoring to match team standards #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
force-pushed
the
remove-vendor
branch
4 times, most recently
from
cc6e1f5
to
86bf287
Compare
Although the caching functionality of go vendoring is nice, it clutters the Git repo and makes changes hard to track. Additionally, `go mod verify` would need to be called in CI to ensure no local changes were made. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
yiraeChristineKim
approved these changes
May 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the caching functionality of go vendoring is nice, it clutters the Git repo and makes changes hard to track. Additionally,
go mod verifywould need to be called in CI to ensure no local changes were made.