fix for ut.block counting a close character within a regex #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2022 09:09
…. Solved by not counting close character when followed by a /. This is not the most robust solution as other combinations of open/close characters within regex structures could trigger a similar error.
|
I think the block function is always going to be subject to breaking. I've rewritten the extraction code for the next update so that it only looks for the beginning and end signatures of the required block and uses the pinch function instead of traversing the code. In that way, it doesn't matter what obstacles are placed in between. The only thing that can then break is if they change the start and end signatures. Nothing is perfect, but less code is better code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other variations of this problem could surface with similar code changes and so a fully robust solution is needed for the long term.