-
Notifications
You must be signed in to change notification settings - Fork 25
Smash gg #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jessemtso
wants to merge
29
commits into
garsh0p:master
Choose a base branch
from
ripgarpr:SmashGG
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Smash gg #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wrong fork? |
…population on GUI, and javascript to handle the api call to populate the map of bracket names
Server.py edited to handle getting the discluded_phases from the POST args. Changed frontend where id of checkbox holds the phase id being checked
…heckboxes and puts them in the post params
…nput node to hold the phase id
…the post params right away.
… object. Fails exclusion test.
…G bracket map as opposed to a parameter in url path
…t list of excluded phases from SmashGG imports
…ment url input into the textbox.
…excluded phases to send to the api.
…xcluded phases. remove those groups from all the groups total. Then we can only process groups still in the overall list
In Progress: Status message telling user phases are being pulled from Smash GG In Progress: Clearing Smash GG data on modal losing focus.
…rted Feature: Disable Submit button until http call to get phases comes back.
… messages to help user insert correct url.
…cus. Prevents silly errors or reloading the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test PR