Skip to content

fix(browse): use --outdir for Windows node server build #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garrett-fox wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix(browse): use --outdir for Windows node server build #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions browse/scripts/build-node-server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,17 @@ DIST_DIR="$GSTACK_DIR/browse/dist"

echo "Building Node-compatible server bundle..."

# Step 1: Transpile server.ts to a single .mjs bundle (externalize runtime deps)
# Step 1: Transpile server.ts to a bundle in DIST_DIR (externalize runtime deps).
# Bun emits the entry as server.js plus any native assets (e.g. ngrok) alongside
# it, so --outdir is required — --outfile rejects multi-output builds.
bun build "$SRC_DIR/server.ts" \
--target=node \
--outfile "$DIST_DIR/server-node.mjs" \
--outdir "$DIST_DIR" \
--external playwright \
--external playwright-core \
--external diff \
--external "bun:sqlite"
mv "$DIST_DIR/server.js" "$DIST_DIR/server-node.mjs"

# Step 2: Post-process
# Replace import.meta.dir with a resolvable reference
Expand Down