fix(browse): honor proxy env vars in Playwright launches#916
Open
ningfeemic-dev wants to merge 1 commit intogarrytan:mainfrom
Open
fix(browse): honor proxy env vars in Playwright launches#916ningfeemic-dev wants to merge 1 commit intogarrytan:mainfrom
ningfeemic-dev wants to merge 1 commit intogarrytan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
gstack browseso Chromium navigation honors standard proxy environment variables.Closes #915
What changed
getProxySettings()inbrowse/src/browser-manager.tsHTTPS_PROXY/https_proxyHTTP_PROXY/http_proxyALL_PROXY/all_proxyNO_PROXY/no_proxyproxyinto all Chromium launch paths:chromium.launch(...)chromium.launchPersistentContext(...)launchPersistentContext(...)Validation
Before fix, proxied environments could still fail with:
After patch + rebuild locally: