Skip to content

fix(browse): add path validation to upload command #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garagon wants to merge 1 commit into from
Closed

fix(browse): add path validation to upload command #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion browse/src/write-commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,9 +399,19 @@ export async function handleWriteCommand(
const [selector, ...filePaths] = args;
if (!selector || filePaths.length === 0) throw new Error('Usage: browse upload <selector> <file1> [file2...]');

// Validate all files exist before upload
// Validate paths are within safe directories (same check as cookie-import)
const safeDirs = [TEMP_DIR, process.cwd()];
for (const fp of filePaths) {
if (!fs.existsSync(fp)) throw new Error(`File not found: ${fp}`);
if (path.isAbsolute(fp)) {
const resolvedFp = path.resolve(fp);
if (!safeDirs.some(dir => isPathWithin(resolvedFp, dir))) {
throw new Error(`Path must be within: ${safeDirs.join(', ')}`);
}
}
if (path.normalize(fp).includes('..')) {
throw new Error('Path traversal sequences (..) are not allowed');
}
}

const resolved = await bm.resolveRef(selector);
Expand Down
Loading