Custom crop sx/sy/sw/sh #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function (_callback) { | ||
| gmImage.format({ | ||
| // All params should exist and be numeric. | ||
| var hasCrop = _.every(customCrop, function(param){ |
|
Very nice. What happens if you customCrop an area outside the bounds of the image? |
|
I tested it, it just goes to the width of the image. I'm happy with that. Good job @AshKyd . |
|
GM handles this by returning a smaller image based on the data it has. If it's completely outside bounds GM will return the original. I've added a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally crop the source image as the first operation.
Moved the
gmImage.sizecall to after the initial crop (so aspect calcs are correct) which is why the diff is so messy.