fix: remove caret from puppeteer version #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aw-davidson
changed the title
garris
approved these changes
Feb 15, 2019
garris
added a commit
that referenced
this pull request
Feb 25, 2019
Owner
|
@aw-davidson sorry, I had to revert this. The report on your PR was broken. Also, the new puppeteer has a different rendering behavior -- because of this some of the tests were running inconsistently. If you'd like to give this another try would you please make sure you can get consistent results when running this 👉 https://github.com/garris/BackstopJS/blob/master/test/configs/backstop_features.js Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor version changes in puppeteer result in version changes for chrome. Downloading the latest minor version of puppeteer is problematic for projects that skip chromium download.