Skip to content

Conversation

@brendonbribeiro
Copy link
Contributor

@brendonbribeiro brendonbribeiro commented Jan 17, 2019

I was updating our version of React, when suddenly the images stopped appearing. I undo my changes but still the problem persisted.

And stopping to better analyze the versions that were in package.lock and package.json I noticed that some were different.
This can happen because we use ^ in front of the versions. I think it's a good practice to leave our dependencies fixed, to avoid problems like this.

dependencies devDependencies

In the image above, the dependencies that are marked in the background are the ones that were different. If for some reason I delete my package.lock the puppeteer that will be installed will be 1.11 for example.

@garris Another thing I noticed is that probably the diverged version of npm is outdated, that's why some PRs are coming with the wrong diverged.js file.


It would be nice if you could publish a new version for npm, which I will already update in this PR.

Thanks!

@garris garris merged commit 53e63e2 into garris:master Jan 18, 2019
@garris
Copy link
Owner

garris commented Jan 18, 2019

Thank you!

@brendonbribeiro brendonbribeiro deleted the deps-version-issues branch January 18, 2019 09:51
garris added a commit that referenced this pull request Jan 21, 2019
@garris
Copy link
Owner

garris commented Jan 21, 2019

Hi @brendonbarreto -- Just fyi -- I had to revert this PR. Somehow -- this config broke the scrubber 😞.

It's probably something easy to fix -- I just ran out of time to track it down. Feel free to put up an update.

Thanks for all your help -- I finally published your version without PhantomJS today 😀.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants