Fixing issues with dependencies versioning #960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating our version of React, when suddenly the images stopped appearing. I undo my changes but still the problem persisted.
And stopping to better analyze the versions that were in
package.lockandpackage.jsonI noticed that some were different.This can happen because we use
^in front of the versions. I think it's a good practice to leave our dependencies fixed, to avoid problems like this.In the image above, the dependencies that are marked in the background are the ones that were different. If for some reason I delete my
package.lockthe puppeteer that will be installed will be1.11for example.@garris Another thing I noticed is that probably the
divergedversion ofnpmis outdated, that's why some PRs are coming with the wrongdiverged.jsfile.It would be nice if you could publish a new version for
npm, which I will already update in this PR.Thanks!