Skip to content

Conversation

@1276stella
Copy link
Contributor

Solve issue #1166
There are two issues:

  1. The card slot, instead of the card itself, retains the approveStatus. On the filtered failed page, when I approve the 1st card, its approveStatus changes from Initial -> Pending -> Approved. After filterTests is dispatched, the 1st card is removed from the page. However, its Approved status remains on the page. Fix: change Approved status to Initial.
  2. The index of the card on the current filtered page is used to find the right test to approve. But this is not correct since the same card on the all page and the failed page has different indices. Fix: use fileName to find the test to approve.

Before
Before

After
After

Copy link
Owner

@garris garris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@garris garris merged commit 9f57299 into garris:master Apr 9, 2020
@Alexbirvik
Copy link

@garris @1276stella Hi guys! I don't have button "approve" in my reports and I didn't find any information how to add it. Your help well be super appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants