Output server logs and handle SIGTERM#68
Draft
Guiorgy wants to merge 4 commits into
Draft
Conversation
define the entrypoint after installing dependencies, so the dependencies can be cached for subsequent builds
Also replaced cat with a while to avoid creating a subshell. Together, this allows for proper handling of the SIGTERM signal when stopping the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
svnservehas the option--log-file:--log-file ARG : svnserve log fileI added a
docker-entrypoint.shscript that creates a named pipe usingmkfifo, runssvnservein the background and then redirects logs from the named pipe to the stdout for Docker. Once a SIGTERM is received, sends the SIGTERM signal to thesvnservein the background.I also added the
.gitattributesfile, since I'm on Windows git tries to 'fix' line endings to\r\nand Docker doesn't like that.And finally, before the container would never terminate gracefully when stopped, it would always be killed after the grace period. Now, the SIGTERM signal should be correctly forwarded to
svnserve, which closes the named pipe after it's done, which also breaks the while loop terminating the whole entrypoint script.