Fix/disable IMDSv1 #2174
Merged
Fix/disable IMDSv1 #2174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akendo <akendo@akendo.eu> We need to provide for access to the metadata service a token now. Hence, try to fetch one token *before* making the test in a subshell. Not a clean solution, but one that should work. Solves: Security-2
Signed-off-by: Akendo <akendo@akendo.eu>
fwilhe
reviewed
Jun 28, 2024
| @@ -5,7 +5,9 @@ | |||
| def test_metadata_connection(client, non_azure, non_ali, non_chroot, non_kvm): | |||
| metadata_host = "169.254.169.254" | |||
| (exit_code, output, error) = client.execute_command( | |||
| f"wget --timeout 5 http://{metadata_host}" | |||
| f"wget --timeout 5 \ | |||
| --header=\"X-aws-ec2-metadata-token: $(curl -sqX PUT 'http://{metadata_host}/latest/api/token' -H 'X-aws-ec2-metadata-token-ttl-seconds: 21600')\" \ | |||
There was a problem hiding this comment.
From the perspective of readability, i would prefer not to get this token value in a subshell command.
Any reason against splitting this into two? Might make it more readable and more easy to debug in case of failure. Also this can include an assertion on the expected return value of the api/token endpoint.
fwilhe
approved these changes
Jun 28, 2024
Signed-off-by: Akendo <akendo@akendo.eu>
Signed-off-by: Akendo <akendo@akendo.eu>
|
@Akendo Thanks for taking care. Porting it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have to disable the IMDSv1. The test will fail without a token. So we request a token from IMDSv2 and provide it for our current test case.