Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e runner (go variant) #95

Merged
merged 29 commits into from
Jul 3, 2019
Merged

Conversation

OlegLoewen
Copy link
Contributor

What this PR does / why we need it:
add e2e runner (go variant)

Release note:

add e2e runner (go variant)

@OlegLoewen OlegLoewen requested a review from a team as a code owner June 14, 2019 11:02
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 14, 2019
@OlegLoewen OlegLoewen force-pushed the e2etestv2 branch 2 times, most recently from fcbf067 to 77c29fe Compare June 24, 2019 13:30
@OlegLoewen OlegLoewen changed the title [WIP][DO NOT MERGE] add e2e runner (go variant) add e2e runner (go variant) Jun 24, 2019
@OlegLoewen OlegLoewen force-pushed the e2etestv2 branch 2 times, most recently from e75d150 to d668a03 Compare June 25, 2019 06:22
@OlegLoewen
Copy link
Contributor Author

WIP status closed, ready for review.

.test-defs/conformanceTestgrid.yaml Outdated Show resolved Hide resolved
test/e2etest/config/config.go Outdated Show resolved Hide resolved
test/e2etest/config/config.go Outdated Show resolved Hide resolved
test/e2etest/config/config.go Outdated Show resolved Hide resolved
test/e2etest/config/config.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/results_evaluator.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/results_evaluator.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/results_evaluator.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/results_evaluator.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/results_evaluator.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/setup/setup.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/setup/setup.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/setup/setup.go Outdated Show resolved Hide resolved
test/e2etest/kubetest/xml_junit_result.go Outdated Show resolved Hide resolved
test/e2etest/util/util.go Outdated Show resolved Hide resolved
test/e2etest/util/util.go Outdated Show resolved Hide resolved
return fallback
}

func RunCmd(command, execPath string) error {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should also let the stdout and stderr parameter customizable.

Then this functions could be reused for all commands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's discuss in person how the interface should look like

test/e2etest/util/util.go Outdated Show resolved Hide resolved
@OlegLoewen OlegLoewen force-pushed the e2etestv2 branch 4 times, most recently from 4dd2707 to c134147 Compare June 26, 2019 14:33
@schrodit
Copy link

@OlegLoewen @dguendisch maybe we should move the e2e tests to a folder outside of <root>/test.
I think <root>/integration-tests/e2e could be a good directory as we currently mix the testmachinery tests and k8s e2e test.
This would be clearer and we are able to add more tests that are testing gardener/kubernetes not the testmachinery there.

@dguendisch
Copy link
Member

dguendisch commented Jun 28, 2019

Good idea.

@OlegLoewen OlegLoewen force-pushed the e2etestv2 branch 3 times, most recently from e56a8ed to 45d4743 Compare July 2, 2019 10:57
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

OlegLoewen added 25 commits July 3, 2019 09:12
Add failed testcase names to test summary
Fix "no Go files" error for cmd run
add debug argument
…flakeAttempts, testcasegroup.

Fix: setting up test utilities
Fix: switching to antoher k8sRelese
@OlegLoewen OlegLoewen merged commit c3b2a13 into gardener:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants