-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add e2e runner (go variant) #95
Conversation
fcbf067
to
77c29fe
Compare
e75d150
to
d668a03
Compare
WIP status closed, ready for review. |
test/e2etest/util/util.go
Outdated
return fallback | ||
} | ||
|
||
func RunCmd(command, execPath string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should also let the stdout and stderr parameter customizable.
Then this functions could be reused for all commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's discuss in person how the interface should look like
4dd2707
to
c134147
Compare
@OlegLoewen @dguendisch maybe we should move the e2e tests to a folder outside of |
Good idea. |
e56a8ed
to
45d4743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…s and e2e.log files.
Use TM export path and kubeconfig path Reuse test-infra util functions Additional minor fixes
Check for errors for util.RunCmd calls
Add failed testcase names to test summary Fix "no Go files" error for cmd run add debug argument
…flakeAttempts, testcasegroup. Fix: setting up test utilities Fix: switching to antoher k8sRelese
Fix refactring issues
…ubectl is not preinstalled
What this PR does / why we need it:
add e2e runner (go variant)
Release note: