Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ipFamilies to be set by testrunner #574

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind task

What this PR does / why we need it:

Expand the configuration options available to a flavor by adding an ipFamilies field.
This will allow writing tests using the newly introduced flag to the shoot creation framework (gardener/gardener#11135).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

cc @ScheererJ

Release note:

Enable `ipFamilies` to be set by testrunner

@hendrikKahl hendrikKahl requested a review from a team as a code owner January 10, 2025 15:03
@gardener-robot gardener-robot added the needs/review Needs review label Jan 10, 2025
@gardener-robot gardener-robot added area/testing Testing related kind/task General task size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 10, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 10, 2025
@hendrikKahl hendrikKahl force-pushed the testrunner/ip-families branch from 7cb829a to 206b91e Compare January 10, 2025 15:05
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 10, 2025
@hendrikKahl hendrikKahl force-pushed the testrunner/ip-families branch from 206b91e to 98a1a68 Compare January 14, 2025 09:02
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 14, 2025
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 14, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 14, 2025
@hendrikKahl hendrikKahl merged commit cf972c3 into gardener:master Jan 14, 2025
11 checks passed
@hendrikKahl hendrikKahl deleted the testrunner/ip-families branch January 14, 2025 09:14
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants