-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure k8s archives can be downloaded #534
Merged
hendrikKahl
merged 2 commits into
gardener:master
from
hendrikKahl:kubetest-download-to-local
Sep 20, 2024
Merged
Ensure k8s archives can be downloaded #534
hendrikKahl
merged 2 commits into
gardener:master
from
hendrikKahl:kubetest-download-to-local
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K8s stopped publishing archives to the legacy gcs bucket. Instead everyting is availalbe via https://dl.k8s.io/<version>. This breaks the old kubetest that is still in use here. To overcome the immediate problem (no conformance test for new patch versions runs) downloading the files directly seems to be the best way. Moving to kubetest2 or another tool to run the conformance tests should be considered in near future.
dguendisch
reviewed
Sep 20, 2024
Co-authored-by: Dieter Guendisch <dieter.guendisch@sap.com>
dguendisch
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/testing
Testing related
kind/technical-debt
Something that is only solved on the surface, but requires more (re)work to be done properly
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind technical-debt
What this PR does / why we need it:
K8s stopped publishing archives to the legacy gcs bucket. Instead everyting is availalbe via https://dl.k8s.io/. This breaks the old kubetest that is still in use here.
To overcome the immediate problem (no conformance test for new patch versions runs) downloading the files directly seems to be the best way.
Moving to kubetest2 or another tool to run the conformance tests should be considered in near future.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/invite @dguendisch
Release note: