Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure k8s archives can be downloaded #534

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind technical-debt

What this PR does / why we need it:
K8s stopped publishing archives to the legacy gcs bucket. Instead everyting is availalbe via https://dl.k8s.io/. This breaks the old kubetest that is still in use here.
To overcome the immediate problem (no conformance test for new patch versions runs) downloading the files directly seems to be the best way.

Moving to kubetest2 or another tool to run the conformance tests should be considered in near future.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

NONE

K8s stopped publishing archives to the legacy gcs bucket. Instead
everyting is availalbe via https://dl.k8s.io/<version>. This breaks the
old kubetest that is still in use here.
To overcome the immediate problem (no conformance test for new patch
versions runs) downloading the files directly seems to be the best way.

Moving to kubetest2 or another tool to run the conformance tests should
be considered in near future.
@hendrikKahl hendrikKahl requested a review from a team as a code owner September 20, 2024 10:48
@gardener-robot gardener-robot added the needs/review Needs review label Sep 20, 2024
@gardener-robot gardener-robot added area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 20, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 20, 2024
Co-authored-by: Dieter Guendisch <dieter.guendisch@sap.com>
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 20, 2024
@hendrikKahl hendrikKahl merged commit 78bfeac into gardener:master Sep 20, 2024
11 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants