Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create_pr_k8s_conformance.py #492

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Update create_pr_k8s_conformance.py #492

merged 1 commit into from
Jan 24, 2024

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
Fix conversion to string when checking the pr.head.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@hendrikKahl hendrikKahl requested a review from a team as a code owner January 23, 2024 15:20
@gardener-robot gardener-robot added needs/review Needs review area/testing Testing related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2024
dguendisch
dguendisch approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 24, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 24, 2024
@hendrikKahl
Update create_pr_k8s_conformance.py
f40098f 
fix conversion to string
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 24, 2024
@hendrikKahl hendrikKahl merged commit 1c8a1a1 into master Jan 24, 2024
11 checks passed
@hendrikKahl hendrikKahl deleted the hendrikKahl-patch-1 branch January 24, 2024 09:30
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hendrikKahl @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot