Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv pipeline-code from refs/meta/ci:branch.cfg into default-branch #478

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Nov 30, 2023

Move most contents from refs/meta/ci branch.cfg into default branch. Note that there is a corresponding change that should be done alongside of merging this pull-request (cannot be done via GitHub Pull-Request).

@ccwienk ccwienk requested a review from a team as a code owner November 30, 2023 13:04
@gardener-robot-ci-3
Copy link
Contributor

This PR proposes changes that would break the pipeline definition:

<invalid YAML>: found undefined alias 'ti_docker_images'
  in "<unicode string>", line 80, column 13:
            <<: *ti_docker_images
                ^

@ccwienk ccwienk force-pushed the refactor-pipeline-definition branch from a262dc1 to 8e3c0ee Compare November 30, 2023 13:05
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 30, 2023
@gardener-robot-ci-3
Copy link
Contributor

This PR proposes changes that would break the pipeline definition:

<invalid YAML>: found undefined alias 'ti_docker_images'
  in "<unicode string>", line 80, column 13:
            <<: *ti_docker_images
                ^

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@ccwienk ccwienk force-pushed the refactor-pipeline-definition branch from 8e3c0ee to 99d487b Compare November 30, 2023 13:06
@gardener-robot-ci-3
Copy link
Contributor

This PR proposes changes that would break the pipeline definition:

test-infra-refactor-pipeline-definition: Traceback (most recent call last):
  File "/usr/lib/python3.11/site-packages/concourse/replicator.py", line 141, in render
    definition_descriptor = self._render(definition_descriptor)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/concourse/replicator.py", line 185, in _render
    'definition': factory.create_pipeline_definition(),
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/concourse/factory.py", line 88, in create_pipeline_definition
    self._apply_traits(variant)
  File "/usr/lib/python3.11/site-packages/concourse/factory.py", line 172, in _apply_traits
    for step in transformer.inject_steps():
  File "/usr/lib/python3.11/site-packages/concourse/model/traits/publish.py", line 475, in inject_steps
    for img in self.trait.dockerimages():
  File "/usr/lib/python3.11/site-packages/concourse/model/traits/publish.py", line 347, in dockerimages
    image_dict = self.raw['dockerimages']
                 ~~~~~~~~^^^^^^^^^^^^^^^^
KeyError: 'dockerimages'

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 30, 2023
@ccwienk ccwienk force-pushed the refactor-pipeline-definition branch from 99d487b to 8eb24c1 Compare November 30, 2023 13:10
@gardener-robot-ci-3
Copy link
Contributor

The pipeline-definition has been fixed.

@ccwienk
Copy link
Member Author

ccwienk commented Nov 30, 2023

The pipeline-definition has been fixed.

thank you, @gardener-robot-ci-3

@ccwienk
Copy link
Member Author

ccwienk commented Nov 30, 2023

this is the remaining branch.cfg we should use after merging this pull-request:

cfgs:
  default:
    branches: ['master']

  release-branches:
    branches: ['rel-.*', 'hotfix-.*']
    inherit:
      test-infra:
        jobs:
          release:
            traits:
              version:
                preprocess: 'finalize'
              release:
                nextversion: 'bump_patch'

@ccwienk
Copy link
Member Author

ccwienk commented Nov 30, 2023

@dguendisch @hendrikKahl : after merging this pull-request (and updating refs/meta/ci branch.cfg), I will create a second pull-request proposing change from GCR -> Artifact-Registry.
I think it should be easier to do those changes in two separate attempts.

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@hendrikKahl hendrikKahl force-pushed the refactor-pipeline-definition branch from 8eb24c1 to 6d9ede9 Compare November 30, 2023 14:41
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
Copy link
Contributor

@hendrikKahl hendrikKahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 30, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 30, 2023
@hendrikKahl hendrikKahl merged commit 6bf7cb9 into master Nov 30, 2023
11 checks passed
@hendrikKahl hendrikKahl deleted the refactor-pipeline-definition branch November 30, 2023 14:53
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 30, 2023
@hendrikKahl
Copy link
Contributor

4cc7ef4 updates the branch.cfg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants